Fix #6182: Add Google Batch LogsPolicy PATH option for GCS bucket log… #6431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
emmarogge
force-pushed
the
fix-issue-6182
branch
3 times, most recently
from
be1236d to
71f6f4a
Compare
… bucket log storage - Add logsBucket configuration option to BatchConfig - Support both CLOUD_LOGGING (default) and PATH log destinations - Add validation for GCS bucket paths (must start with gs://) - Include comprehensive tests for new functionality - Maintain backward compatibility 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: David Glazer <[email protected]>
emmarogge
force-pushed
the
fix-issue-6182
branch
from
71f6f4a to
1371aa6
Compare
- Add helper methods to extract bucket names and convert GCS paths to mount paths - Ensure logs bucket is mounted as Volume in GoogleBatchScriptLauncher - Update LogsPolicy to use container mount paths instead of GCS paths - Add comprehensive tests for bucket mounting and path conversion - Addresses reviewer feedback about missing bucket mounting requirements This ensures Google Batch can write logs to the specified GCS bucket by properly mounting it before referencing it in the LogsPolicy PATH. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Emma Rogge <[email protected]>
1. Rename variable due to existing variable with same name. 2. Specify parameter type as string. Signed-off-by: Emma Rogge <[email protected]>
emmarogge
force-pushed
the
fix-issue-6182
branch
from
1371aa6 to
b105b0e
Compare
|
@bentsherman I had a quick chat with @dglazer, this PR is ready for review (sounds like marking the PR as not draft can only be done by someone with write access? idk) |
|
@dglazer thanks for the contribution. What's the benefit of being able to send logs to a bucket instead of the standard cloud logging? |
|
Thanks for taking a look @bentsherman . The short answer is that it lets us provide a unified management experience to researchers, with the same ACLs controlling access to workflow inputs, outputs, and logs, and without them having to be familiar with GCP-native logging tools. @emmarogge can provide more details if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… storage
🤖 Generated with Claude Code
NOTE: this change still needs human review.
Signed-off-by: David Glazer [email protected]